-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
CI: skip ninja installation in linux_qemu workflows #27827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The ninja used in the workflow is the one from the host. Skipping ninja installation in the container allows to workaround issues that could arise when building it from source as is currently the case with riscv64.
Could add a comment about why the ninja requirement is removed. I'm wondering what upstream change caused the sudden appearance of these failures. |
there really is no good reason to build ninja from source inside the container. So this PR is desirable even if we could have built ninja successfully. |
Co-authored-by: Matti Picus <[email protected]>
The build-backend changed from scikit-build to scikit-build-core. There are no c++ modifications. I don't know yet what caused the build to fail here (The build is passing native/qemu riscv64 compilation. NumPy is using a cross-compilation setup which I've not tried to reproduce yet). |
Thanks @mayeut |
Just FYI, the failure comes from the following:
Those 2 factors explain why the compilation is now failing for ninja ( |
@mayeut thanks for digging into this. |
The ninja used in the workflow is the one from the host.
Skipping ninja installation in the container allows to workaround issues that could arise when building it from source as is currently the case with riscv64.
xref: scikit-build/ninja-python-distributions#226 (comment)
cc @mattip