Towards fixing the Py2 bug in #163 #165
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error in #163 seems to come from a combination of changes between 0.7 and 0.8:
str
due topydoc.getdoc
explicitly encoding its result (https://github.com/python/cpython/blob/2.7/Lib/pydoc.py#L85).I'm not sure yet how to fix this completely. SphinxDocString currently provides
__str__
and not__unicode__
. But the__str__
implementation can currently return aunicode
in py2, resulting in automatic casting / encoding.