Skip to content

FIX remove duplicated citation back-references #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2019
Merged

FIX remove duplicated citation back-references #180

merged 2 commits into from
Apr 2, 2019

Conversation

jnothman
Copy link
Member

@jnothman jnothman commented Jun 6, 2018

As noted in #169, this is due to a sphinx bug that allows references in only::latex directives to result in backreferences even when the builder is not latex. In this PR we remove backreferences whose referencing IDs do not exist.

Fixes #169

@jnothman jnothman mentioned this pull request Jun 6, 2018
Closed
larsoner
larsoner approved these changes Jun 6, 2018
View reviewed changes
Copy link
Collaborator

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rebuilt the scipy docs with this change and can confirm it works, thanks @jnothman !

Other than one nitpick, LGTM +1 for merge

@jnothman
Copy link
Member Author

jnothman commented Apr 2, 2019

I'm happy to merge this with @larsoner's approval and road testing if that's okay by you @rgommers.

@rgommers
Copy link
Member

rgommers commented Apr 2, 2019

@jnothman please do!

@larsoner you've done quite a bit of work on numpydoc and the SciPy Sphinx docs. Would you like commit rights for numpydoc?

@larsoner
Copy link
Collaborator

larsoner commented Apr 2, 2019

Sure, happy to help with review + merge in this repo as well

@rgommers
Copy link
Member

rgommers commented Apr 2, 2019

great, I added you

@rgommers rgommers merged commit 40b3733 into numpy:master Apr 2, 2019
@rgommers
Copy link
Member

rgommers commented Apr 2, 2019

okay just pressed the green button. thanks @jnothman and @larsoner

@larsoner larsoner mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner approved these changes

Assignees
No one assigned
Labels
type: Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnothman @rgommers @larsoner