Skip to content

Generate requirements files from pyproject.toml #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Aug 2, 2023

This PR was proposed in #481 (comment) which makes pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks @mwtoews

@rgommers rgommers merged commit 94ef7f0 into numpy:main Aug 3, 2023
@mwtoews mwtoews deleted the gen-requirements-from-pyproject branch August 3, 2023 09:18
@jarrodmillman jarrodmillman added this to the 1.6.0 milestone Aug 17, 2023
jarrodmillman added a commit to jarrodmillman/networkx that referenced this pull request Oct 5, 2023
This PR is based on numpy/numpydoc#483 and scikit-image/scikit-image#7085,
which make pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files.
It doesn't really change anything, but I would like to keep everything
consistent.
jarrodmillman added a commit to networkx/networkx that referenced this pull request Oct 6, 2023
* Generate requirements files from pyproject.toml

This PR is based on numpy/numpydoc#483 and scikit-image/scikit-image#7085,
which make pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files.
It doesn't really change anything, but I would like to keep everything
consistent.

* Cleanup formatting
Alex-Markham pushed a commit to Alex-Markham/networkx that referenced this pull request Oct 13, 2023
* Generate requirements files from pyproject.toml

This PR is based on numpy/numpydoc#483 and scikit-image/scikit-image#7085,
which make pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files.
It doesn't really change anything, but I would like to keep everything
consistent.

* Cleanup formatting
dschult pushed a commit to BrunoBaldissera/networkx that referenced this pull request Oct 23, 2023
* Generate requirements files from pyproject.toml

This PR is based on numpy/numpydoc#483 and scikit-image/scikit-image#7085,
which make pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files.
It doesn't really change anything, but I would like to keep everything
consistent.

* Cleanup formatting
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* Generate requirements files from pyproject.toml

This PR is based on numpy/numpydoc#483 and scikit-image/scikit-image#7085,
which make pyproject.toml a primary file without any template, and adds a pre-commit script to write requirements files.
It doesn't really change anything, but I would like to keep everything
consistent.

* Cleanup formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants