Skip to content

Add config for pre-commit bot #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

jarrodmillman
Copy link
Member

@larsoner On other projects, I've used this configuration for the pre-commit.ci bot. I am not sure how it works without the config. Thoughts or suggestions?

@jarrodmillman jarrodmillman added this to the 1.6.0 milestone Aug 17, 2023
@jarrodmillman jarrodmillman requested a review from larsoner August 17, 2023 15:57
@larsoner larsoner merged commit 1433d66 into numpy:main Aug 17, 2023
@larsoner
Copy link
Collaborator

Thanks @jarrodmillman

@larsoner
Copy link
Collaborator

larsoner commented Aug 17, 2023

I am not sure how it works without the config.

We use no EDIT: custom bot config on MNE-Python and it has worked well so far. People haven't complained about style fixes being pushed to their PRs at least. And the updates don't come super often (1-2 / mo?) but that'll depend on the hooks used. For us it's mostly black and ruff that update, and they're usually useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants