Skip to content

feat(module): add meta.maintainers attribute #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,9 @@ PRs to add new formatters are welcome!
In order to add a new formatter do the following things:

1. Create a new entry in the `./programs/` folder.
2. Run `./examples.sh` to update the `./examples` folder.
3. To test the program:
2. Consider adding yourself as the `meta.maintainer` (see below).
3. Run `./examples.sh` to update the `./examples` folder.
4. To test the program:
1. Extend the project's `./treefmt.nix` file (temporarily) to enable the new
formatter and configure it in whatever manner is appropriate.
2. Add a bunch of pertinent sources in this repo -- for instance, if the new
Expand All @@ -348,7 +349,17 @@ In order to add a new formatter do the following things:
badly-formatted files are flagged as such. Re-run `nix fmt` and confirm
that no additional changes were made.
4. Once this is good, revert those changes.
4. Submit the PR!
5. Submit the PR!

### Definition of a `meta.maintainer`

You can register your desire to help with a specific formatter by adding your
GitHub handle to the module's `meta.maintainers` list.

That mostly means, for the given formatter:

- You get precedence if any decisions need to be made.
- Getting pinged if any issue is being found.

## Commercial support

Expand Down
15 changes: 15 additions & 0 deletions module-options.nix
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,21 @@ in
default = true;
};

# Meta attributes
meta = {
maintainers = lib.mkOption {
type = lib.types.listOf lib.types.str;
internal = true;
default = [ ];
example = lib.literalExpression ''[ "zimbatm" ]'';
description = ''
List of github users responsible for a formatter.

This option should be defined at most once per module.
'';
};
};

# Outputs
build = {
devShell = mkOption {
Expand Down
2 changes: 2 additions & 0 deletions programs/actionlint.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.actionlint;
in
{
meta.maintainers = [ ];

options.programs.actionlint = {
enable = lib.mkEnableOption "actionlint";
package = lib.mkPackageOption pkgs "actionlint" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/alejandra.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.alejandra;
in
{
meta.maintainers = [ ];

options.programs.alejandra = {
enable = lib.mkEnableOption "alejandra";
package = lib.mkPackageOption pkgs "alejandra" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/asmfmt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.asmfmt;
in
{
meta.maintainers = [ ];

options.programs.asmfmt = {
enable = lib.mkEnableOption "asmfmt";
package = lib.mkPackageOption pkgs "asmfmt" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/beautysh.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.beautysh;
in
{
meta.maintainers = [ ];

options.programs.beautysh = {
enable = lib.mkEnableOption "beautysh";
package = lib.mkPackageOption pkgs "beautysh" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/dhall.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.dhall;
in
{
meta.maintainers = [ ];

options.programs.dhall = {
enable = lib.mkEnableOption "Dhall";
lint = lib.mkOption {
Expand Down
2 changes: 2 additions & 0 deletions programs/dos2unix.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.dos2unix;
in
{
meta.maintainers = [ ];

options.programs.dos2unix = {
enable = lib.mkEnableOption "dos2unix";
package = lib.mkPackageOption pkgs "dos2unix" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/dprint.nix
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ let
null;
in
{
meta.maintainers = [ ];

options.programs.dprint = {
enable = mkEnableOption "dprint";
package = mkPackageOption pkgs "dprint" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/elm-format.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.elm-format;
in
{
meta.maintainers = [ ];

options.programs.elm-format = {
enable = lib.mkEnableOption "elm-format";

Expand Down
2 changes: 2 additions & 0 deletions programs/erlfmt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.erlfmt;
in
{
meta.maintainers = [ ];

options.programs.erlfmt = {
enable = lib.mkEnableOption "erlfmt";
package = lib.mkPackageOption pkgs "erlfmt" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/fantomas.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{ lib, pkgs, config, ... }:
let cfg = config.programs.fantomas;
in {
meta.maintainers = [ ];

options.programs.fantomas = {
enable = lib.mkEnableOption "fantomas";
package = lib.mkPackageOption pkgs "fantomas" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/fnlfmt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.fnlfmt;
in
{
meta.maintainers = [ ];

options.programs.fnlfmt = {
enable = lib.mkEnableOption "fnlfmt";
package = lib.mkPackageOption pkgs "fnlfmt" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/formatjson5.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.formatjson5;
in
{
meta.maintainers = [ ];

options.programs.formatjson5 = {
enable = lib.mkEnableOption "formatjson5";
package = lib.mkPackageOption pkgs "formatjson5" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/fourmolu.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.fourmolu;
in
{
meta.maintainers = [ ];

options.programs.fourmolu = {
enable = lib.mkEnableOption "fourmolu";
package = lib.mkOption {
Expand Down
2 changes: 2 additions & 0 deletions programs/fprettify.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.fprettify;
in
{
meta.maintainers = [ ];

options.programs.fprettify = {
enable = lib.mkEnableOption "fprettify";
package = lib.mkPackageOption pkgs "fprettify" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/gdformat.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.gdformat;
in
{
meta.maintainers = [ ];

options.programs.gdformat = {
enable = lib.mkEnableOption "gdformat";
package = lib.mkPackageOption pkgs "gdtoolkit_4" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/gofmt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.gofmt;
in
{
meta.maintainers = [ "zimbatm" ];

options.programs.gofmt = {
enable = lib.mkEnableOption "gofmt";
package = lib.mkPackageOption pkgs "go" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/gofumpt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.gofumpt;
in
{
meta.maintainers = [ "zimbatm" ];

options.programs.gofumpt = {
enable = lib.mkEnableOption "gofumpt";
package = lib.mkPackageOption pkgs "gofumpt" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/google-java-format.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.google-java-format;
in
{
meta.maintainers = [ ];

options.programs.google-java-format = {
enable = lib.mkEnableOption "google-java-format";
package = lib.mkPackageOption pkgs "google-java-format" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/hclfmt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ let
cfg = config.programs.hclfmt;
in
{
meta.maintainers = [ "zimbatm" ];

options.programs.hclfmt = {
enable = lib.mkEnableOption "hclfmt";
package = lib.mkPackageOption pkgs "hclfmt" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/hlint.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.hlint;
in
{
meta.maintainers = [ ];

options.programs.hlint = {
enable = lib.mkEnableOption "hlint";
package = lib.mkPackageOption pkgs "hlint" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/isort.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.isort;
in
{
meta.maintainers = [ ];

options.programs.isort = {
enable = lib.mkEnableOption "isort";
package = lib.mkPackageOption pkgs "isort" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/jsonfmt.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{ lib, pkgs, config, ... }:
let cfg = config.programs.jsonfmt;
in {
meta.maintainers = [ ];

options.programs.jsonfmt = {
enable = lib.mkEnableOption "jsonfmt";
package = lib.mkPackageOption pkgs "jsonfmt" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/jsonnet-lint.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.jsonnet-lint;
in
{
meta.maintainers = [ ];

options.programs.jsonnet-lint = {
enable = lib.mkEnableOption "jsonnet";
package = lib.mkPackageOption pkgs "go-jsonnet" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/jsonnetfmt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.jsonnetfmt;
in
{
meta.maintainers = [ ];

options.programs.jsonnetfmt = {
enable = lib.mkEnableOption "jsonnet";
package = lib.mkPackageOption pkgs "go-jsonnet" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/just.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.just;
in
{
meta.maintainers = [ ];

options.programs.just = {
enable = lib.mkEnableOption "just";
package = lib.mkPackageOption pkgs "just" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/keep-sorted.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.keep-sorted;
in
{
meta.maintainers = [ ];

options.programs.keep-sorted = {
enable = lib.mkEnableOption "keep-sorted";
package = lib.mkPackageOption pkgs "keep-sorted" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/ktfmt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.ktfmt;
in
{
meta.maintainers = [ ];

options.programs.ktfmt = {
enable = lib.mkEnableOption "ktfmt";
package = lib.mkPackageOption pkgs "ktfmt" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/ktlint.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.ktlint;
in
{
meta.maintainers = [ ];

options.programs.ktlint = {
enable = lib.mkEnableOption "ktlint";
package = lib.mkPackageOption pkgs "ktlint" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/leptosfmt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.leptosfmt;
in
{
meta.maintainers = [ ];

options.programs.leptosfmt = {
enable = lib.mkEnableOption "leptosfmt";
package = lib.mkPackageOption pkgs "leptosfmt" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/mdformat.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.mdformat;
in
{
meta.maintainers = [ ];

options.programs.mdformat = {
enable = lib.mkEnableOption "mdformat";
package = lib.mkPackageOption pkgs [ "python3Packages" "mdformat" ] { };
Expand Down
2 changes: 2 additions & 0 deletions programs/mdsh.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.mdsh;
in
{
meta.maintainers = [ "zimbatm" ];

options.programs.mdsh = {
enable = lib.mkEnableOption "mdsh";
package = lib.mkPackageOption pkgs "mdsh" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/mix-format.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.mix-format;
in
{
meta.maintainers = [ ];

options.programs.mix-format = {
enable = lib.mkEnableOption "mix-format";
package = lib.mkPackageOption pkgs "elixir" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/muon.nix
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ let
cfg = config.programs.muon;
in
{
meta.maintainers = [ ];

options.programs.muon = {
enable = lib.mkEnableOption "muon";
package = lib.mkPackageOption pkgs "muon" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/mypy.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{ lib, pkgs, config, ... }:
{
meta.maintainers = [ ];

options.programs.mypy = {
enable = lib.mkEnableOption "mypy";
package = lib.mkPackageOption pkgs "mypy" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/nickel.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.nickel;
in
{
meta.maintainers = [ ];

options.programs.nickel = {
enable = lib.mkEnableOption "nickel";
package = lib.mkPackageOption pkgs "nickel" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/nimpretty.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.nimpretty;
in
{
meta.maintainers = [ ];

options.programs.nimpretty = {
enable = lib.mkEnableOption "nimpretty";
package = lib.mkPackageOption pkgs "nim" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/nixfmt-rfc-style.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.nixfmt-rfc-style;
in
{
meta.maintainers = [ ];

options.programs.nixfmt-rfc-style = {
enable = lib.mkEnableOption "nixfmt-rfc-style";
package = lib.mkPackageOption pkgs "nixfmt-rfc-style" { };
Expand Down
2 changes: 2 additions & 0 deletions programs/nixfmt.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ let
cfg = config.programs.nixfmt;
in
{
meta.maintainers = [ ];

options.programs.nixfmt = {
enable = lib.mkEnableOption "nixfmt";
package = lib.mkPackageOption pkgs "nixfmt-rfc-style" { };
Expand Down
Loading