Skip to content

chore(ruff): split into ruff-format and ruff-check #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Aug 10, 2024

This fixes ./example.sh and nix flake check. They depends on having .enable options.

This fixes ./example.sh and `nix flake check`. They depends on having
.enable options.
@zimbatm
Copy link
Member Author

zimbatm commented Aug 10, 2024

/cc @elohmeier

enable = lib.mkEnableOption "ruff formatter" // {
description = ''
Whether to enable the Ruff formatter, an extremely fast Python code formatter
designed as a drop-in replacement for Black.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd question this bit somewhat, but I see what you mean

@declension
Copy link
Contributor

Does this also fix all the

trace: Obsolete option `programs.ruff.enable' is used. It was renamed to `programs.ruff.check'.

we now see everywhere?

@zimbatm zimbatm enabled auto-merge (squash) August 28, 2024 08:13
@zimbatm
Copy link
Member Author

zimbatm commented Aug 28, 2024

the constant warning was fixed separately (#214 and #218)

@zimbatm zimbatm merged commit 0b9a693 into main Aug 28, 2024
245 checks passed
@zimbatm zimbatm deleted the ruff-split branch August 28, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants