fix mouse

[ekrenzin]

Description

I experienced the issue described in #126. I tested out the solution to the issue (listed in the original post) and confirmed that the provided change resolved the problem for me.

Steps to reproduce:

It's extremely easy to reproduce the bug, and notably, the x coordinate moves as well. To reproduce, run the following code:

function loop() {
 try {
   const mp = libnut.getMousePos()
   libnut.moveMouse(mp.x, mp.y)
   console.log('loop', mp)
   loop()
 } catch (e) {
   console.log('loop error', e)
 }
}

loop()

Expected:

The cursor should stay in the same position.

Result:

The cursor moves to "breakpoints" where it stops; if the cursor is moved from a "breakpoint," it will begin creeping towards the next one.

Comments

The solution worked well in testing, however, if this solution does not work for the repo, is there another solution that could be implemented?

I hope all is well @s1hofmann & thank you for maintaining!

[s1hofmann]

Hi @ekrenzin 👋

everything is fine on my end, thanks for asking!

I will brush up on this topic once again before merging, thanks for opening the PR to get things rolling!

All the best

Simon

[ekrenzin]

Hey @s1hofmann !

I wanted to follow up on this PR to see if there was anything blocking which I could help with looking into. I understand you are busy, so I truly appreciate the time you take to look into these issues.

Let me know what I can do to assist you :)

Best,
Ean

[s1hofmann]

Hi @ekrenzin 👋

I had another look at both code and docs and came to the conclusion that the added addition just tips over the rounding process to avoid the drift.

I'd prefer wrapping the calculation into a call to ceil instead of the addition, did you give this a try yet?

Thanks for your contribution! ❤️

All the best

Simon

[s1hofmann]

Included in https://github.com/nut-tree/libnut-core/tree/v2.5.1

[ekrenzin]

@s1hofmann I really appreciate you making that PR! I was about to sit down and work on the change you requested and saw it was done! Thank you so much!

[s1hofmann]

@ekrenzin You're welcome. Took a while until I found the time to sit down and have a proper look.