-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add focus & resize window functions #164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
s1hofmann
reviewed
Jun 9, 2023
s1hofmann
reviewed
Jun 9, 2023
s1hofmann
requested changes
Jun 28, 2023
s1hofmann
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: PR: Add
focusWindow
andresizeWindow
FunctionalityDescription
This pull request introduces new functionality to the window manager. With the modifications made in this PR, users can now focus on a specific window and resize it using its window handle. The implementation covers all supported platforms - Windows, macOS, and Linux.
Changes
focusWindow
andresizeWindow
.focusWindow
andresizeWindow
to permission checks.focusWindow
andresizeWindow
for Linux using Xlib.focusWindow
andresizeWindow
for macOS using Objective-C++ and the Cocoa API.focusWindow
andresizeWindow
, enabling them to be called from JavaScript.focusWindow
andresizeWindow
for Windows using Win32 API.focusWindow
andresizeWindow
.New Functions
focusWindow(handle: number): void;
Focuses the window specified by the provided window handle. Brings the window to the foreground and gives it input focus.
resizeWindow(handle: number, width: number, height: number): void;
Resizes the window specified by the provided window handle to the given width and height.
Testing
Please test these changes by trying to focus and resize the window using their respective new functions on all supported platforms. Verify that the functions return appropriate boolean values indicating the success of the operation.
Impact
These changes should not impact any existing functionality in the application. Instead, they provide the users with new capabilities of focusing and resizing windows from their application.
Open Issue
#18