Skip to content

Feature/19/os_folders #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2020
Merged

Feature/19/os_folders #21

merged 3 commits into from
Jul 31, 2020

Conversation

s1hofmann
Copy link
Member

This PR introduces separate folders for OS specific implementation.
Using these folders makes it easier to split implementation files without having to keep a pre- / postifx like ..._win32.c on files.

@s1hofmann s1hofmann linked an issue Jul 31, 2020 that may be closed by this pull request
Separate folders for OS specific implementation #19
Closed
@s1hofmann s1hofmann requested a review from svettwer July 31, 2020 08:03
svettwer
svettwer approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@svettwer svettwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of separating source code like that. Maybe we could untangle some pre-processor stuff like that as well.

@s1hofmann s1hofmann merged commit 366626e into develop Jul 31, 2020
@s1hofmann s1hofmann deleted the feature/19/os_folders branch July 31, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svettwer svettwer svettwer approved these changes

Assignees

@s1hofmann s1hofmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate folders for OS specific implementation
2 participants
@s1hofmann @svettwer