Skip to content

Retrieve window dimensions #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 59 commits into from
Aug 11, 2020
Merged

Conversation

s1hofmann
Copy link
Member

This PR addresses several issues at once.

It implements functionality to retrieve dimensions of a window given its window handle (#17).
getWindows retrieves a list of all available window handles, getWindowRect returns window dimensions in form of

{
    x,
    y,
    width,
    height
}

Additionally, getActiveWindow retrieves the handle of the currently active window (#15).

getWindowTitle returns a window's title (#22)

Simon Hofmann and others added 30 commits August 3, 2020 10:08
…t-tree/libnut into feature/17/retrieve_window_dimensions
Copy link
Contributor

@svettwer svettwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this code needs an 18+ age rating, because it's porn! 😂
The way to test the implementation E2E with a simple electron app is creative as f*** and covers all platforms by just one test file. The implementation is clean an simple. I bet more time has been invested than it seems at the first place.

But it wouldn't be a review of mine, if there were no remarks or questions. 😉

@svettwer svettwer assigned s1hofmann and unassigned svettwer Aug 10, 2020
@s1hofmann s1hofmann assigned svettwer and unassigned s1hofmann Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants