-
-
Notifications
You must be signed in to change notification settings - Fork 35
Retrieve window dimensions #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…handles and window dimensions by handle
… in getWindowRect
…t-tree/libnut into feature/17/retrieve_window_dimensions
…inDisplay functions
…handled equally on all platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this code needs an 18+ age rating, because it's porn! 😂
The way to test the implementation E2E with a simple electron app is creative as f*** and covers all platforms by just one test file. The implementation is clean an simple. I bet more time has been invested than it seems at the first place.
But it wouldn't be a review of mine, if there were no remarks or questions. 😉
Co-authored-by: Sven Hettwer <[email protected]>
Co-authored-by: Sven Hettwer <[email protected]>
This PR addresses several issues at once.
It implements functionality to retrieve dimensions of a window given its window handle (#17).
getWindows
retrieves a list of all available window handles,getWindowRect
returns window dimensions in form ofAdditionally,
getActiveWindow
retrieves the handle of the currently active window (#15).getWindowTitle
returns a window's title (#22)