Skip to content

Feature/20/code splitting #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 29, 2020
Merged

Feature/20/code splitting #29

merged 8 commits into from
Sep 29, 2020

Conversation

s1hofmann
Copy link
Member

This PR closes #20

@s1hofmann s1hofmann added the enhancement New feature or request label Sep 5, 2020
@s1hofmann s1hofmann requested a review from svettwer September 9, 2020 15:53
svettwer
svettwer approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@svettwer svettwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like! 👍

The separation between platforms makes it much easier to read the code. On the other hand, the build process is slightly more complex as it was before but I absolutely think that this is a great trade of.

@s1hofmann s1hofmann merged commit 45529ed into develop Sep 29, 2020
@s1hofmann s1hofmann deleted the feature/20/code_splitting branch September 29, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svettwer svettwer svettwer approved these changes

Assignees

@s1hofmann s1hofmann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split OS specific implementation into separate files
2 participants
@s1hofmann @svettwer