Skip to content

Bugfix/45/whole screen region screenshots #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2021

Conversation

s1hofmann
Copy link
Member

No description provided.

@s1hofmann s1hofmann linked an issue Jan 23, 2021 that may be closed by this pull request
@s1hofmann s1hofmann requested a review from svettwer January 31, 2021 15:00
Copy link
Contributor

@svettwer svettwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there are a bunch of warnings. Is this something you would consider to fix in the scope of this PR or is it something you'd create a dedicated issue for?

@svettwer
Copy link
Contributor

svettwer commented Feb 2, 2021

In addition: May I suggest to add the change to the change log already? This would reduce the amount of changelog maintenance during release.

@s1hofmann
Copy link
Member Author

I updated the changelog and opened #53 to fix compiler warnings.

@s1hofmann s1hofmann merged commit 8f81ad9 into develop Feb 23, 2021
@s1hofmann s1hofmann deleted the bugfix/45/whole_screen_region_screenshots branch February 23, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region captures can't capture the whole screen
2 participants