Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve dimensions for a window specified via its window handle #17

Closed
s1hofmann opened this issue Jul 30, 2020 · 1 comment
Closed

Retrieve dimensions for a window specified via its window handle #17

s1hofmann opened this issue Jul 30, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@s1hofmann
Copy link
Member

Short overview
As a user I want to be able to retrieve the window coordinates (x, y, width, height) for a window specified via its window handle.

Use case
Limiting input to e.g. image search
@s1hofmann s1hofmann added the enhancement New feature or request label Jul 30, 2020
s1hofmann pushed a commit that referenced this issue Aug 3, 2020
(#17) Started window_manager.h interface
ba301b4
s1hofmann pushed a commit that referenced this issue Aug 3, 2020
(#17) window_manager MacOS implementation to retrieve list of window …
b780ff0 
…handles and window dimensions by handle
s1hofmann pushed a commit that referenced this issue Aug 3, 2020
(#17) Updated CmakeLists.txt to include MacOS window_manager implemen…
5b8b55e 
…tation
s1hofmann pushed a commit that referenced this issue Aug 3, 2020
(#17) Export getWindows and getWindowRect functions
1e1108c
s1hofmann pushed a commit that referenced this issue Aug 3, 2020
(#17) Added window_manager source files for both Linux and Windows
65a1997
s1hofmann added a commit that referenced this issue Aug 3, 2020
@s1hofmann
(#17) Changed window handles to int64_t, added getWindowTitle function
36ba190
s1hofmann added a commit that referenced this issue Aug 3, 2020
@s1hofmann
(#17) Updated windowhandle types, added implementation for getWindowT…
c96a86a 
…itle
s1hofmann added a commit that referenced this issue Aug 3, 2020
@s1hofmann
(#17) Windows implementation, WIP
4e92f3c
s1hofmann added a commit that referenced this issue Aug 3, 2020
@s1hofmann
(#17) Exported getWindowTitle
e9d4d7f
s1hofmann added a commit that referenced this issue Aug 3, 2020
@s1hofmann
(#17) Added window_manager source file in Windows
72b1609
s1hofmann pushed a commit that referenced this issue Aug 5, 2020
(#17) Added plattform specific typedef for window handles
2f1cf9b
s1hofmann pushed a commit that referenced this issue Aug 5, 2020
(#17) Refactored window manager macOS implementation
aa4cc6f
s1hofmann pushed a commit that referenced this issue Aug 5, 2020
(#17) Switched to typedef for windowhandle
b273dbb
s1hofmann added a commit that referenced this issue Aug 5, 2020
@s1hofmann
(#17) Changed point and size types to use int64_t
c76079f
s1hofmann added a commit that referenced this issue Aug 5, 2020
@s1hofmann
(#17) Updated Windows implementation
d656baa
s1hofmann added a commit that referenced this issue Aug 5, 2020
@s1hofmann
(#17) WindowHandle now refers to int64_t on all platforms
c5bbe90
s1hofmann added a commit that referenced this issue Aug 5, 2020
@s1hofmann
(#17) Added Linux implementation of window_manager
d934da5
s1hofmann added a commit that referenced this issue Aug 5, 2020
@s1hofmann
(#17) Linux implementation, WIP
b193e7a
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Retrival of window rect, WIP
dc910e1
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Updated getWindows implementation on Linux
fef4c28
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Updated typings
37321e4
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Added integration test
c790569
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Added window integration tests to CI pipelines
7a86432
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Updated test code for window tests
7243b0e
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Removed test code inside electron app
b0325a8
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Switched to Spectron + Jest tests
ac51ca0
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Shortened test script by using added 145 packages in 1.069s
c3dced4 
> [email protected] test /Users/s1hofmann/Documents/git/nut-tree/libnut
> echo 'Error: no test specified'

Error: no test specified
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Updated test to focus our Electron window due to problems with …
785e5b9 
…additional batch windows on Windows
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Trying to work around the batch windows problem
4cd61f6
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Made window toplevel by default
430d6cb
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Focus still does not work with batch windows
01bbe79
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Fixed call of focus on browserWindow
f108dd6
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Add call to minimize before calling focus to fix window focus, …
3bd63cc 
…following electron/electron#2867 (comment)
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Additional timeouts for focus handling
cf18af3
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Added call to restore() to fix issues on macOS
1394e9d
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Moved focus workaround from beforeEach to beforeAll
2ec2fbe
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Removed border offset for x and y coordinates of window rect on…
674b7cb 
… Linux

XGetGeometry returns the outer point of a window and does not require an offset calculation
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Also remove border from width and height
e7d78d3
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Switched to using already existing XGetMainDisplay and XCloseMa…
439de7a 
…inDisplay functions
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Added extern declaration to avoid symbol mangeling
277a948
s1hofmann added a commit that referenced this issue Aug 6, 2020
@s1hofmann
(#17) Fix type conversion
162d7c4
s1hofmann pushed a commit that referenced this issue Aug 7, 2020
(#17) Added additional tests for window handling
e0fccf1
s1hofmann pushed a commit that referenced this issue Aug 7, 2020
(#17) Reverted minimized window test since minimized windows are not …
1017ea8 
…handled equally on all platforms
@s1hofmann s1hofmann mentioned this issue Aug 7, 2020
Merged
s1hofmann pushed a commit that referenced this issue Aug 7, 2020
(#17) Added proper interfaces for return types
95d50c4
s1hofmann pushed a commit that referenced this issue Aug 7, 2020
(#17) Refactored window_manager code on Linux to properly use existin…
107fb79 
…g XGetMainDisplay code
s1hofmann pushed a commit that referenced this issue Aug 10, 2020
(#17) Added doc comment regarding the use of instead of
6d62a7c
s1hofmann pushed a commit that referenced this issue Aug 10, 2020
(#17) Added doc comments to window_manager interface
b81d49e
s1hofmann pushed a commit that referenced this issue Aug 10, 2020
(#17) Handling of possible value for
63b74a7
s1hofmann pushed a commit that referenced this issue Aug 10, 2020
(#17) Added doc comment regarding EnumWindowsProc
204ffdf
s1hofmann pushed a commit that referenced this issue Aug 11, 2020
(#17) Added checks for valid windows
c650f00
s1hofmann pushed a commit that referenced this issue Aug 11, 2020
(#17) Fixed removed variable
0021b37
@s1hofmann
Copy link
Member Author

Closed by #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s1hofmann