Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split OS specific implementation into separate files #20

Closed
s1hofmann opened this issue Jul 30, 2020 · 0 comments · Fixed by #29
Closed

Split OS specific implementation into separate files #20

s1hofmann opened this issue Jul 30, 2020 · 0 comments · Fixed by #29
Assignees
@s1hofmann
Labels
enhancement New feature or request

Comments

@s1hofmann
Copy link
Member

Short overview
Most implementations are done in a single source file with tons of #ifdefs.
I guess it's still valid for header files, but I'm repeatedly getting lost reading the implementation.

Use case

  • Better code splitting
  • Improved readability
  • Easier to include files in CMakeLists.txt without having to deal with OS specific filename postfixes (e.g. *._win32.cc)
@s1hofmann s1hofmann added the enhancement New feature or request label Jul 30, 2020
s1hofmann added a commit that referenced this issue Sep 3, 2020
@s1hofmann
(#20) Split up mouse implementation
5fdcc66
s1hofmann added a commit that referenced this issue Sep 3, 2020
@s1hofmann
(#20) Split keypress.c
3cb2a5c
s1hofmann added a commit that referenced this issue Sep 3, 2020
@s1hofmann
(#20) Fixed include for xdisplay.h
1f6749a
s1hofmann added a commit that referenced this issue Sep 3, 2020
@s1hofmann
(#20) Formatting
3ab73d0
s1hofmann added a commit that referenced this issue Sep 5, 2020
@s1hofmann
(#20) Split screen.c
17e3ccc
s1hofmann added a commit that referenced this issue Sep 5, 2020
@s1hofmann
(#20) Updated CMakeLists.txt with newly added screen implementations
2428ff1
s1hofmann added a commit that referenced this issue Sep 5, 2020
@s1hofmann
(#20) Split screengrab.c
2e3ec50
s1hofmann added a commit that referenced this issue Sep 5, 2020
@s1hofmann
(#20) Split keycode.c
968476c
@s1hofmann s1hofmann mentioned this issue Sep 5, 2020
Merged
@s1hofmann s1hofmann self-assigned this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1hofmann s1hofmann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/20/code splitting nut-tree/libnut-core
1 participant
@s1hofmann