Skip to content

Commit 4e3b180

Browse files
committed
(#455) BREAKING: Remove both searchMultipleScales and confidence from OptionalSearchParameters since these properties would be provider specific and should be handled via providerData
1 parent 163dbce commit 4e3b180

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

lib/optionalsearchparameters.class.ts

+6-8
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,18 @@ import { Region } from "./region.class";
22
import { AbortSignal } from "node-abort-controller";
33

44
/**
5-
* {@link OptionalSearchParameters} serves as a data class holding location parameters for image search
5+
* {@link OptionalSearchParameters} serves as a data class holding optional parameters for search purposes
66
*/
7-
export class OptionalSearchParameters {
7+
export class OptionalSearchParameters<PROVIDER_DATA_TYPE> {
88
/**
99
* {@link OptionalSearchParameters} class constructor
1010
* @param searchRegion Optional {@link Region} to limit the search space to
11-
* @param confidence Optional confidence value to configure image match confidence
12-
* @param searchMultipleScales Optional flag to indicate if the search should be conducted at different scales
1311
* @param abort An {@link AbortSignal} to cancel an ongoing call to `waitFor`
12+
* @param providerData Optional data that gets passed onto the provider implementation
1413
*/
1514
constructor(
16-
public searchRegion?: Region,
17-
public confidence?: number,
18-
public searchMultipleScales?: boolean,
19-
public abort?: AbortSignal
15+
public searchRegion?: Region | Promise<Region>,
16+
public abort?: AbortSignal,
17+
public providerData?: PROVIDER_DATA_TYPE
2018
) {}
2119
}

0 commit comments

Comments
 (0)