Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow screen.find and other to work with non-image needles #455

Closed
s1hofmann opened this issue Dec 14, 2022 · 0 comments
Closed

Allow screen.find and other to work with non-image needles #455

s1hofmann opened this issue Dec 14, 2022 · 0 comments
Labels
BREAKING A breaking change that requires a major release DONE Implementation is done, but not yet merged into master enhancement Enhancement to existing features

Comments

@s1hofmann
Copy link
Member

s1hofmann commented Dec 14, 2022 •
edited
Loading

Short overview
Currently screen.find is tuned to work on image data.
However, this might change in the future to also allow non-image needles so the implementation should be flexible enough to allow for that.

Use case
Searching for other screen content besides images. Windows etc.

Additional info
It might break an API contract with existing plugins
@s1hofmann s1hofmann added enhancement Enhancement to existing features BREAKING A breaking change that requires a major release labels Dec 14, 2022
s1hofmann added a commit that referenced this issue Jan 8, 2023
@s1hofmann
(#455) Made MatchRequest class generic to allow for generic needle ty…
163dbce 
…pes as well as additional generic provider data that gets passed to the provider implementation
s1hofmann added a commit that referenced this issue Jan 8, 2023
@s1hofmann
(#455) BREAKING: Remove both searchMultipleScales and confidence from…
4e3b180 
… OptionalSearchParameters since these properties would be provider specific and should be handled via providerData
s1hofmann added a commit that referenced this issue Jan 8, 2023
@s1hofmann
(#455) Handle generic provider data in ImageFinder interface
106209a
s1hofmann added a commit that referenced this issue Jan 8, 2023
@s1hofmann
(#455) New query types to enable searching for things other than images
a3a2f05
s1hofmann added a commit that referenced this issue Jan 8, 2023
@s1hofmann
(#455) New interfaces to search for text or windows
b0026d9
s1hofmann added a commit that referenced this issue Jan 8, 2023
@s1hofmann
(#455) Added new provider interfaces to registry, changed log level o…
e6d6f0f 
…f register events to trace
s1hofmann added a commit that referenced this issue Jan 8, 2023
@s1hofmann
(#455) Revert removing confidence property from OptionalSearchParameters
c6bc38a
s1hofmann added a commit that referenced this issue Jan 8, 2023
@s1hofmann
(#455) Extended find implementation conforms all existing tests
2de9643
@s1hofmann s1hofmann mentioned this issue Jan 8, 2023
Merged
s1hofmann added a commit that referenced this issue Jan 8, 2023
@s1hofmann
(#455) Increase coverage
d66dffc
s1hofmann added a commit that referenced this issue Jan 9, 2023
@s1hofmann
(#455) Allow broader input on toShow jest matcher
eba13ba
s1hofmann added a commit that referenced this issue Jan 9, 2023
@s1hofmann
(#455) Refactor handling of finder implementations, add tests
1d78e2e
s1hofmann added a commit that referenced this issue Jan 9, 2023
@s1hofmann
(#455) Added tests for different find queries
a28a734
s1hofmann added a commit that referenced this issue Jan 9, 2023
@s1hofmann
(#455) Added find input validation and tests
4fbc167
s1hofmann added a commit that referenced this issue Jan 9, 2023
@s1hofmann
(#455) Query tests
103f226
s1hofmann added a commit that referenced this issue Jan 9, 2023
@s1hofmann
(#455) Tests for DefaultProviderRegistry
7c120e8
s1hofmann added a commit that referenced this issue Jan 9, 2023
@s1hofmann
(#455) Remove commented lines
6757d10
s1hofmann added a commit that referenced this issue Jan 9, 2023
@s1hofmann
Feature/455/non image find (#461)
c619f02 
* (#455) Made MatchRequest class generic to allow for generic needle types as well as additional generic provider data that gets passed to the provider implementation

* (#455) BREAKING: Remove both searchMultipleScales and confidence from OptionalSearchParameters since these properties would be provider specific and should be handled via providerData

* (#455) Handle generic provider data in ImageFinder interface

* (#455) New query types to enable searching for things other than images

* (#455) New interfaces to search for text or windows

* (#455) Added new provider interfaces to registry, changed log level of register events to trace

* (#455) Revert removing confidence property from OptionalSearchParameters

* (#455) Extended find implementation conforms all existing tests

* (#455) Increase coverage

* (#455) Allow broader input on toShow jest matcher

* (#455) Refactor handling of finder implementations, add tests

* (#455) Added tests for different find queries

* (#455) Added find input validation and tests

* (#455) Query tests

* (#455) Tests for DefaultProviderRegistry

* (#455) Remove commented lines
@s1hofmann s1hofmann added the DONE Implementation is done, but not yet merged into master label Jan 9, 2023
s1hofmann added a commit that referenced this issue Jan 14, 2023
@s1hofmann
(#455) Export new provider interfaces
3193ec0
s1hofmann added a commit that referenced this issue Jan 14, 2023
@s1hofmann
(#455) Export new find queries
c6b52f1
s1hofmann added a commit that referenced this issue Jan 15, 2023
@s1hofmann
(#455) Limit text queries to string input
3058567
s1hofmann added a commit that referenced this issue Jan 15, 2023
@s1hofmann
(#455) Fix parameter type for text query helper methods
b67dd46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BREAKING A breaking change that requires a major release DONE Implementation is done, but not yet merged into master enhancement Enhancement to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s1hofmann