Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor locationparameters.class.ts #129

Closed
s1hofmann opened this issue May 11, 2020 · 0 comments
Closed

Refactor locationparameters.class.ts #129

s1hofmann opened this issue May 11, 2020 · 0 comments
Labels
maintenance Maintenance tasks to keep code clean and up-to-date
Milestone
v1.4.2

Comments

@s1hofmann
Copy link
Member

Short overview
Refactor LocationParameters to better reflect its purpose

Detailed description
Currently Screen#find and Screen#waitFor take optional LocationParameters.
Since LocationParameters not only hold search location data, but also a possible confidence value to override Screen.config.confidence, naming is not quite correct.
Something like e.g. OptionalSearchParameters should be used in favour.
@s1hofmann s1hofmann added the maintenance Maintenance tasks to keep code clean and up-to-date label May 11, 2020
@s1hofmann s1hofmann added this to the v1.5.0 milestone May 11, 2020
s1hofmann added a commit that referenced this issue Jul 12, 2020
@s1hofmann
(#129) Added OptionalSearchParameters class
80b73c1
s1hofmann added a commit that referenced this issue Jul 12, 2020
@s1hofmann
(#129) Re-export new OptionalSearchParameters class to not break exis…
2e787ec 
…ting API
s1hofmann added a commit that referenced this issue Jul 12, 2020
@s1hofmann
(#129) Export new parameters class
b462314
s1hofmann added a commit that referenced this issue Jul 12, 2020
@s1hofmann
(#129) Updated docs comments to refer to new parameters class
4e1f04e
s1hofmann added a commit that referenced this issue Jul 12, 2020
@s1hofmann
(#129) Updated docs
6767a85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Maintenance tasks to keep code clean and up-to-date
Projects
None yet
Milestone
v1.4.2
Development

No branches or pull requests
1 participant
@s1hofmann