Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API overhaul #53

Closed
s1hofmann opened this issue Mar 31, 2019 · 1 comment
Closed

API overhaul #53

s1hofmann opened this issue Mar 31, 2019 · 1 comment
Assignees
@s1hofmann
Labels
enhancement Enhancement to existing features

Comments

@s1hofmann
Copy link
Member

Short overview
Some APIs, e.g. mouse actions could be refactored for better usability.

Use case
Increased usability of APIs

Detailed description
Some APIs, e.g. mouse actions in combination with image search are quite cumbersome.

await mouse.move(await movement.straightTo(Location.centerOf(await screen.find("plus.png"))));

vs.

await mouse.move(straightTo(centerOf(screen.find("plus.png"))));

Additional content

Please provide any (mandatory) additional data for your enhancement
@s1hofmann s1hofmann added the enhancement Enhancement to existing features label Mar 31, 2019
@s1hofmann s1hofmann self-assigned this Mar 31, 2019
s1hofmann added a commit that referenced this issue Mar 31, 2019
@s1hofmann
(#53) Further code cleanup
4f0dd01 
- Refactored code to get rid of tick method for mouse and keyboard input
- Decreased keyboard typing speed
s1hofmann added a commit that referenced this issue Mar 31, 2019
@s1hofmann
(#53) Refactored Location class into functions
f283b61
s1hofmann added a commit that referenced this issue Mar 31, 2019
@s1hofmann
(#53) Increased test timeout
8241432
s1hofmann added a commit that referenced this issue Mar 31, 2019
@s1hofmann
(#53) Refactored MovementType class into function
1ed8ddf
s1hofmann added a commit that referenced this issue Mar 31, 2019
@s1hofmann
(#53) Refactored Movement class into separate functions
25e1414
s1hofmann added a commit that referenced this issue Mar 31, 2019
@s1hofmann
(#53) Updated to new API
a04e134
s1hofmann added a commit that referenced this issue Mar 31, 2019
@s1hofmann
(#53) Updated to new API
7495ba3
s1hofmann added a commit that referenced this issue Mar 31, 2019
@s1hofmann
(#53) Removed old files
d22509d
s1hofmann added a commit that referenced this issue Mar 31, 2019
@s1hofmann
(#53) Updated readme
fd65034
@s1hofmann
Copy link
Member Author

Closed by #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1hofmann s1hofmann

Labels
enhancement Enhancement to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s1hofmann