(#200) Maintenance/GitHub actions ci #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of 640x480 in XVFB action
…own on macOS workers
svettwer
suggested changes
Jan 7, 2021
There was a problem hiding this comment.
LGTM. 🚀 👍
Just some remarks concerning minor changes and steps that could be omitted in my opinion. As I assume some copy paste action was involved, these remarks can be found in all pipelines which is the cause for the amount of remarks.
Concerning repo config: It would make sense to remove the app veyor checks as they have been removed.
|
Kudos, SonarCloud Quality Gate passed!
|
svettwer
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three workflows:
ci.yaml: CI runs for branches and pull requests (runs sonar + all tests on all platforms / node versions)snapshot_release.yaml: Runs on develop and releases a new snapshot package on successtagged_release.yaml: Runs on semver tags (v*..) and releases a new latest package on successBoth Appveyor checks are failing since I haven't removed the project yet.
I'd like to wait until this PR is merged before finally deleting the Appveyor CI project.