feat: support setting kubeadm ignorePreflightErrors #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/feat-nodeRegistration
branch
2 times, most recently
from
fda72a5 to
389ca11
Compare
dkoshkin
force-pushed
the
dkoshkin/feat-nodeRegistration
branch
from
389ca11 to
60207a2
Compare
dkoshkin
changed the title
faiq
reviewed
Apr 4, 2025
Set default ignorePreflightErrors: ["SystemVerification"]
dlipovetsky
reviewed
Apr 9, 2025
jimmidyson
reviewed
Apr 9, 2025
dkoshkin
force-pushed
the
dkoshkin/feat-nodeRegistration
branch
from
26509f1 to
45a9cc2
Compare
dkoshkin
force-pushed
the
dkoshkin/feat-nodeRegistration
branch
from
baebaad to
136090b
Compare
jimmidyson
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Exposes CAPI's API to configure kubeadm.
This enables working around kubernetes/kubernetes#129462 or ignoring any other kubeadm preflight check.
I intentionally added it as this to mimic CAPIs APIs under a single handler so that we can expose additional configuration in the future.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Tested with a Docker cluster and verified the generated templates.
Also unit tests.
Special notes for your reviewer:
Eventhough in CAPI's API
taintsare also part ofnodeRegistration, there is more nuance there that deserves its own handler. KeepingtaintsandnodeRegistrationalso allows to change the implementation of taints in the future to a controller based approach that doesn't require a rollout of new Machines.