This repository was archived by the owner on Mar 18, 2021. It is now read-only.
Update jsdom to version 9.4.0 🚀 #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100%
|
nutgaard
force-pushed
the
greenkeeper-jsdom-9.4.0
branch
from
6a9d5bc to
5202459
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
jsdom just published its new version 9.4.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of jsdom.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 25 commits .
5d66130Version 9.4.08134159Fix the value of clicked inside checkbox click events42c700aAdd custom agent support17996d3Implement frameElement for Windowa56b11dSet iframe document referrers correctlyed0d5f9Load s when their href changes5f58a34Load script elements when they gain a src attribute112b221Rename our scripting languages test24c28fdAdd evalVMScript public APIbc8c3cfConvert living-dom/attributes.js test to a web platform test7182006Named access nested context revision63f8010Re-implement FormData9a9c5fbUpdate our disabled semantics to more closely match the spec99057f3Fix loading of external images (with canvas package installed)8ac615fDon't use syntax that doesn't work in Node v4 (yet)There are 25 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade