Skip to content

feat(google-tag-manager): add <noscript> fallback (#263) #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 31, 2019

Conversation

derz
Copy link
Contributor

@derz derz commented Jul 22, 2019

@atinux
Copy link
Member

atinux commented Jul 30, 2019

@derz nuxt/vue-meta#410 has been merged :)
You can use pbody: true

@derz
Copy link
Contributor Author

derz commented Aug 12, 2019

thanks @atinux. Changed in the last commit :-)

@TheAlexLichter TheAlexLichter requested a review from atinux August 18, 2019 07:49
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR.
One question I have is for head when defined as a function, cc @manniL & @pi0

@atinux atinux requested a review from pi0 August 19, 2019 09:04
@pi0 pi0 changed the title feat: add <noscript> fallback, refs #263 feat(google-tag-manager): add <noscript> fallback (#263) Aug 19, 2019
@atinux atinux requested review from pi0 and removed request for pi0 August 29, 2019 12:20
@pi0 pi0 merged commit f0dd65f into nuxt-community:master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google-tag-manager does not add noscript to body element.
4 participants