Skip to content

fix: keep same behavior with vue in handling Unknown type on defineModel #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Apr 24, 2025

not sure if there are any edge cases where we need to convert Unknown -> something else

@danielroe danielroe requested a review from Teages April 24, 2025 13:02
Copy link

pkg-pr-new bot commented Apr 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/vue-sfc-transformer@37

commit: 4f2afcc

Teages
Teages previously requested changes Apr 24, 2025
@Teages Teages dismissed their stale review April 24, 2025 16:41

fixed

@Teages Teages changed the title fix: don't use Unknown constructor fix: keep same behavior in handling Unknown type on defineModel Apr 24, 2025
@Teages Teages changed the title fix: keep same behavior in handling Unknown type on defineModel fix: keep same behavior with vue in handling Unknown type on defineModel Apr 24, 2025
@Teages Teages merged commit 83737b7 into main Apr 24, 2025
4 checks passed
@Teages Teages deleted the fix/unknown-model branch April 24, 2025 16:46
@danielroe
Copy link
Member Author

thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants