Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

feat(template): support package.json and handler #467

Merged
merged 4 commits into from
Apr 17, 2020
Merged

feat(template): support package.json and handler #467

merged 4 commits into from
Apr 17, 2020

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Apr 12, 2020

Add package.json and package.js for each package.

With this pr, we can support

  • Auto deps pr from renovate, then we can keep updating packages to latest version
  • Isolate each template package into its own dir
  • Easier to add a new framework and better control by user package.js

@clarkdo clarkdo requested review from atinux, pi0 and a team April 12, 2020 13:39
atinux
atinux approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, great work!

@clarkdo clarkdo merged commit ff37dc8 into master Apr 17, 2020
@clarkdo clarkdo deleted the feat/package branch April 17, 2020 16:14
NickBolles
NickBolles reviewed Apr 23, 2020
View reviewed changes
packages/cna-template/template/nuxt/package.js
delete pkg.devDependencies['lint-staged']
}
if (!stylelint) {
lintStaged && delete pkg['lint-staged']['*.{css,vue']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this missing the trailing }?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clarkdo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed in #493

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NickBolles NickBolles NickBolles left review comments

@atinux atinux atinux approved these changes

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clarkdo @atinux @NickBolles