This repository was archived by the owner on Mar 4, 2025. It is now read-only.
feat: update design #792
Merged
feat: update design #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
May 26, 2021
|
Shall we keep |
|
Already conditionally added, see https://github.com/nuxt/create-nuxt-app/blob/feat/design-update/packages/create-nuxt-app/lib/saofile.js#L69 |
|
icon is fine. sorry gh diff was showing |
clarkdo
approved these changes
May 26, 2021
|
Yes, do you mind updating the PR? 🙏 When good; feel free to merge and release 🔥 |
|
OK， I’ll update and do some tests tmr |
|
@atinux |
|
Good for me @clarkdo |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should look like this now: