Skip to content

fix(types): missing property "content" of MetaPropertyEquiv #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2019
Merged

fix(types): missing property "content" of MetaPropertyEquiv #436

merged 1 commit into from
Aug 27, 2019

Conversation

SilentDepth
Copy link
Contributor

According to MDN and WHATWG, a <meta http-equiv> should contain a content attribute and no name attribute. The MetaPropertyEquiv interface seems wrong about this case and this PR is going to fix the issue.

Closes #435.

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #436   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735be09...ce3865e. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #436   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735be09...ce3865e. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #436   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735be09...ce3865e. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #436   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735be09...ce3865e. Read the comment docs.

Copy link
Collaborator

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pimlie pimlie merged commit 4384f44 into nuxt:master Aug 27, 2019
@HerrBertling
Copy link

Shouldn't this have been a breaking change?

This changes the API of vue-meta and people using this would have broken http-equiv meta tags when updating without active switch from name to content.

@pimlie
Copy link
Collaborator

pimlie commented Sep 3, 2019

@HerrBertling but it wasnt valid html anyway? Also it shouldnt break anything in most cases because the base MetaDataProperty has a [key: string]: any type property

@HerrBertling
Copy link

Ah, okay :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[types] missing content in MetaPropertyEquiv
3 participants