-
Notifications
You must be signed in to change notification settings - Fork 246
fix(types): missing property "content" of MetaPropertyEquiv #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 34 34
Lines 547 547
Branches 153 153
=====================================
Hits 547 547 Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 34 34
Lines 547 547
Branches 153 153
=====================================
Hits 547 547 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 34 34
Lines 547 547
Branches 153 153
=====================================
Hits 547 547 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 34 34
Lines 547 547
Branches 153 153
=====================================
Hits 547 547 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Shouldn't this have been a breaking change? This changes the API of |
@HerrBertling but it wasnt valid html anyway? Also it shouldnt break anything in most cases because the base MetaDataProperty has a |
Ah, okay :) Thanks! |
According to MDN and WHATWG, a
<meta http-equiv>
should contain acontent
attribute and noname
attribute. TheMetaPropertyEquiv
interface seems wrong about this case and this PR is going to fix the issue.Closes #435.