fix: correct mappings in README quickstart, fix navigate in buffers, fixes #212

Author: cseickel

README.md

@@ -130,13 +130,6 @@ use {
             ["s"] = "open_vsplit",
             ["t"] = "open_tabnew",
             ["C"] = "close_node",
-            ["<bs>"] = "navigate_up",
-            ["."] = "set_root",
-            ["H"] = "toggle_hidden",
-            ["R"] = "refresh",
-            ["/"] = "fuzzy_finder",
-            ["f"] = "filter_on_submit",
-            ["<c-x>"] = "clear_filter",
             ["a"] = "add",
             ["A"] = "add_directory",
             ["d"] = "delete",
@@ -147,6 +140,7 @@ use {
             ["c"] = "copy", -- takes text input for destination
             ["m"] = "move", -- takes text input for destination
             ["q"] = "close_window",
+            ["R"] = "refresh",
           }
         },
         nesting_rules = {},
@@ -174,12 +168,24 @@ use {
                                 -- "disabled",    -- netrw left alone, neo-tree does not handle opening dirs
           use_libuv_file_watcher = false, -- This will use the OS level file watchers to detect changes
                                           -- instead of relying on nvim autocmd events.
+          window = {
+            mappings = {
+              ["<bs>"] = "navigate_up",
+              ["."] = "set_root",
+              ["H"] = "toggle_hidden",
+              ["/"] = "fuzzy_finder",
+              ["f"] = "filter_on_submit",
+              ["<c-x>"] = "clear_filter",
+            }
+          }
         },
         buffers = {
           show_unloaded = true,
           window = {
             mappings = {
               ["bd"] = "buffer_delete",
+              ["<bs>"] = "navigate_up",
+              ["."] = "set_root",
             }
           },
         },
@@ -198,6 +204,7 @@ use {
           }
         }
       })
+
       vim.cmd([[nnoremap \ :Neotree reveal<cr>]])
     end
 }

lua/neo-tree/sources/buffers/commands.lua

@@ -63,7 +63,7 @@ end
 ---Navigate up one level.
 M.navigate_up = function(state)
   local parent_path, _ = utils.split_path(state.path)
-  buffers.navigate(parent_path)
+  buffers.navigate(state, parent_path)
 end
 
 M.open = cc.open
@@ -81,7 +81,7 @@ M.set_root = function(state)
   local tree = state.tree
   local node = tree:get_node()
   if node.type == "directory" then
-    buffers.navigate(node.id)
+    buffers.navigate(state, node.id)
   end
 end
 

lua/neo-tree/sources/common/file-items.lua

@@ -4,6 +4,8 @@ local utils = require("neo-tree.utils")
 local log = require("neo-tree.log")
 local git = require("neo-tree.git")
 
+local unused_to_produce_diagnostic = {}
+
 local function sort_items(a, b)
   if a.type == b.type then
     return a.path < b.path

lua/neo-tree/ui/renderer.lua

@@ -650,14 +650,7 @@ create_window = function(state)
         log.trace("Skipping mapping for %s", cmd)
       else
         if type(func) == "string" then
-          local func_ref = state.commands[func]
-          if func_ref then
-            func = func_ref
-          else
-            log.error(
-              string.format("Could not find command %s for mapping %s in %s", func, cmd, state.name)
-            )
-          end
+          func = state.commands[func]
         end
         if type(func) == "function" then
           keymap.set(state.bufnr, "n", cmd, function()