Skip to content

filter.respect_gitignore = true seems not working on WindowsOS #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lopi-py opened this issue Feb 26, 2022 · 4 comments
Closed

filter.respect_gitignore = true seems not working on WindowsOS #158

lopi-py opened this issue Feb 26, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@lopi-py
Copy link
Contributor

lopi-py commented Feb 26, 2022

also when I set filter.show_hidden = false my .gitignore doesn't render, is this intended?
Edit: I did notice that just not works with directories

@cseickel
Copy link
Contributor

Edit: I did notice that just not works with directories

I don't use neovim on Windows, so I can only guess at the problem, but that is a good clue. I'll take a look.

also when I set filter.show_hidden = false my .gitignore doesn't render, is this intended?

Yes, because the "hidden" files logic is actually using the *nix convention of files that start with a dot are hidden. It does not actually support the Windows version of what is a hidden folder.

@cseickel cseickel added the bug Something isn't working label Feb 26, 2022
@cseickel
Copy link
Contributor

There was a bug I fixed with gitignore not working for directories recently. Can you confirm that you are on the latest release and whether you have set the gitignore_source = "git check-ignore" option?

@lopi-py
Copy link
Contributor Author

lopi-py commented Feb 26, 2022

yes, I'm on the latest release, also when I set gitignore_source = "git check-ignore" also not works with files, since I'm on Windows I'll try to look into it and fix it

cseickel pushed a commit that referenced this issue Feb 26, 2022
chore(utils.lua): remove duplicate definition of M.path_separator
@lopi-py lopi-py closed this as completed Feb 26, 2022
@nyngwang
Copy link

@lopi-py: Joke aside, you missed the s. It's filters.respect_gitignore = true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants