auto_expand_width gets caught in infinite loop and hangs neovim

[cseickel]

I've noticed that with window.auto_expand_width enabled, sometimes neovim will freeze when I open neo-tree as a sidebar. I njust tailed the logs when this happened and saw this scrolling by:

Related to #580
@pysan3 Can you take a look at this?

[pysan3]

Hi, I don't have a pc with me right now so I can't test it right now but it seems that the estimated length of the expanded width is too big that it cannot fit the nvim window.

When there is not enough width for the expanded width, it tries to expand more indefinitely falling into an infinite loop which is causing the nvim to freeze.

I see that the estimated width is over 10,000 but did you purposely put a very very long file name?
Or maybe expanding a recursive directory symlink might explain this problem?

Could you give me a screenshot shot of the sidepanel when setting it off but with a quite big window.width in the first place?

[pysan3]

Oh, the estimated width increments one by one.

This might be a bug in estimating the required width of the resulting panel.

Could you send me your whole neo-tree configuration because I didn't face this issue with my setup?

[cseickel]

I see that the estimated width is over 10,000 but did you purposely put a very very long file name?
Or maybe expanding a recursive directory symlink might explain this problem?

This is just a standard set of files, nothing particularly long and it shouldn't be opening folders recursively. Here is my current config: https://github.com/cseickel/dotfiles/blob/e4189bff222470ad07eeb9c947b4cbc4848b6a86/config/nvim/lua/plugins/config/neo-tree.lua#L2-L294

[pysan3]

Thanks.

One thing I'm concerned is that the width required is not aligned with the strwidth of the content, and I had to add 1 in order to align with what is shown in the window.
Here

Can you guess where this 1 is coming from, and is this actually calculating the width of the window accurately?

EDIT:
I got to my pc but could not replicate the problem...

[pysan3]

When there is not enough width for the expanded width, it tries to expand more indefinitely falling into an infinite loop which is causing the nvim to freeze.

Do you know any vim.api.xxx or something that tells the maximum window width available in current terminal?
If there's any, changing this line could solve the problem.
huge_number

- local huge_number = 2000
+ local huge_number = vim.api.nvim_give_me_the_maximum_possible_window_width(0)

[cseickel]

I think that would be vim.o.columns

[pysan3]

One thing I'm concerned is that the width required is not aligned with the strwidth of the content, and I had to add 1 in order to align with what is shown in the window.
Here

Can you guess where this 1 is coming from, and is this actually calculating the width of the window accurately?

Ok, so it seems that this + 1 is what is causing problem on your case.
I think I got something wrong somewhere not related to this plugin so let's remove this + 1 for now.