Skip to content

docs: add Buffers entry to Nerd Fonts v3 source selector example #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

NReilingh
Copy link
Contributor

I recently reconfigured my terminal and editor, so I'm using v3 nerd fonts. Using the winbar source selector, I noticed icons were broken, so I applied the config suggested in the readme. I realized that the buffers entry was missing, so I determined that the existing code point was 0xf719, nf-mdi-file_document_box:

display_name = "  Buffers "

The equivalent glyph in v3 has a different name, nf-md-text_box, and is at 0xf021a.

This PR adds a line to the readme config example to fix the buffer icon for V3 nerd fonts.

Old code point was 0xf719, which broke in v3. New glyph is 0xf021a.
@cseickel cseickel changed the base branch from v2.x to main July 8, 2023 23:01
@cseickel cseickel changed the title README.md: nerd font v3 config missing buffers docs: add Buffers entry to Nerd Fonts v3 source selector example Jul 8, 2023
@cseickel cseickel merged commit edbc694 into nvim-neo-tree:main Jul 8, 2023
@NReilingh
Copy link
Contributor Author

@cseickel The reason I filed this against branch v2.x is because that's what is currently displayed on the main project page (https://github.com/nvim-neo-tree/neo-tree.nvim), whereas it's kind of useless on main since this already has support for V3 nerd fonts, so the workaround in the README can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants