Skip to content

fix(commands)!: open nested files default to open instead of expand #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

pysan3
Copy link
Collaborator

@pysan3 pysan3 commented Nov 9, 2023

RETRY OF #1219

  • use { "open", config = { expand_nested_files = true } } for old behavior
  • no_expand_file options is deprecated, move to expand_nested_files (OPPOSITE)

I'm not really sure what is going on.

I'm so sorry to spam you with notifications...

- use `{ "open", config = { expand_nested_files = true } }` for old behavior
- `no_expand_file` options is deprecated, move to `expand_nested_files` (OPPOSITE)
@pysan3
Copy link
Collaborator Author

pysan3 commented Nov 9, 2023

Ok, so I haven't change anything but refreshed my fork's main branch by deleting it once and forking the main repo again.

Seems that my fork's main branch was broken in the first place when I synced with upstream somehow.

Now test is passing and I think we are good to go.

@cseickel cseickel merged commit b6d8bee into nvim-neo-tree:main Nov 10, 2023
@pysan3
Copy link
Collaborator Author

pysan3 commented Nov 10, 2023

Hu? Now the test in the main branch seems to be failing @cseickel . Tho you merged this passing merge request.

Is there something wrong with the test itself?

@cseickel
Copy link
Contributor

Is there something wrong with the test itself?

There are occasionally false errors. It has something to do with the asynchronous nature of everything that had to be hacked in and plenary testing in neovim is a small niche project that is not really complete.

It could be that there are better solutions now that are more reliable, but it doesn't fail often enough for me to fix it.

@pysan3
Copy link
Collaborator Author

pysan3 commented Nov 10, 2023

I see. Ok se let's wait for the next commit and hope it's just a random unlucky thing this time.

If not I'll try to look into it but I don't think I can bring something useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants