Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid_tabs before _for_each_state #1604

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

hrsh7th
Copy link
Contributor

@hrsh7th hrsh7th commented Nov 22, 2024

fix #1067

problem

Probably, neovim does not fire the TabClosed autocmd in some conditions.
So invalid tabs might be remained to the manager states.

solution

check & dispose invalid states before enumerate it.

@hrsh7th hrsh7th changed the title remove invalid_tabs before _for_each_state fix: remove invalid_tabs before _for_each_state Nov 22, 2024
Copy link
Contributor

@cseickel cseickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually came here OK to put an "unmaintained notice" on all PRs, this one is too obvious not to merge.

If you have any interest in maintaining another plugin, neo-tree is up for grabs.

@cseickel cseickel merged commit 4ba04f6 into nvim-neo-tree:main Nov 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: neotree directory change error after auto-closing a tab
2 participants