Skip to content

fix(buffers): Normalize paths for buffers source #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dylangiles
Copy link
Contributor

Firstly, for my first contribution to neo-tree, I would like to thank the neo-tree maintainers for producing an such an awesome piece of software. Neo-tree is an integral part of my experience with Neovim as my daily driver, and an amazing example of the wider Neovim ecosystem. I also thank the maintainers for the opportunity to contribute, and welcome any feedback on my contributions.


Paths should be normalized when:

  • Checking their membership in the root directory, and
  • Acquiring their parent paths

before adding them to the buffers source.

This PR fixes issue #1617.

Copy link
Collaborator

@pynappo pynappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked it out on Windows, LGTM @cseickel

@cseickel cseickel merged commit 694fc4b into nvim-neo-tree:main Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants