Skip to content

fix(fs_actions): windowize paths on windows before moving #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

midrare
Copy link
Contributor

@midrare midrare commented Feb 24, 2025

Fix for bad argument to fs_state error when cutting and pasting on Windows.

Closes #1693

pynappo
pynappo previously approved these changes Feb 24, 2025
pynappo
pynappo previously approved these changes Feb 24, 2025

Verified

This commit was signed with the committer’s verified signature.
pynappo pynappo
While utils.normalize_path ought to just normalize paths on linux too,
this minimizes possible regressions in behavior until a future, more
thorough PR can be done.

Verified

This commit was signed with the committer’s verified signature.
pynappo pynappo
@pynappo pynappo changed the title fix(fs_actions): cut and paste broken on windows (#1693) fix(fs_actions): windowize paths on windows before moving Feb 25, 2025
Copy link
Collaborator

@pynappo pynappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the notification spam, originally was going to modify utils.normalize_path but that should be done in a future PR

@pynappo pynappo merged commit e6f5b5e into nvim-neo-tree:main Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: On Windows, cut and paste fails with fs_stat error due to forward slashes in split_path()
2 participants