fix(files): set tree root correctly when revealing in split #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huh, that's just nonsense, but I should have known that! The issue with this PR is that it is targeting v1.x and PRs should go to main. Can you recreate it? I tried ti change it but the protection does not update when I do that. |
aha! yeah will do, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
:NeoTreeRevealInSplit, the tree's root never changes from the working directory. This PR fixes that. I would have thought thatutils.split_path(path_to_reveal)[1]would get the first out of the two things returned bysplit_path(like when you return tuples in Python), but it's actually indexing the first string returned instead (which returnsnil).