Skip to content

feat: use window_picker for split and vsplit as well #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nagy135
Copy link
Contributor

@nagy135 nagy135 commented Apr 22, 2022

Adds option to bind split and vsplit versions of "open with window picker".
Not sure if we wanna bind this to some specific key, as I suggested this should be default behavior ...maybe it should be just suggested as an alternative to split/vsplit as a comment after ?
Have to admit that i m in no sense "lua programmer" so please do some testing, but on my setup it works flawlessly

@nagy135
Copy link
Contributor Author

nagy135 commented Apr 22, 2022

#314

@nagy135 nagy135 changed the base branch from v2.x to main April 22, 2022 11:25
@cseickel
Copy link
Contributor

This looks good except for:

  • You need to target the main branch instead of a release branch.
  • You should document the new commands in doc/neot-tree.txt / :h neo-tree-mappings
  • You might also want to include a reference to them in deafults.lua and README.md, even if they are just commented out by default.

@nagy135 nagy135 force-pushed the feat/window-picker-split-vsplit branch from e553fea to 98386df Compare April 22, 2022 15:08
@nagy135
Copy link
Contributor Author

nagy135 commented Apr 22, 2022

it looks like I m little tired at the end of the week ...I also created it from release branch, stripping your netrw fix. Since rebase on main doesnt seem to register here after pull request is already created, I will create a new one fixing these fck-ups

@nagy135 nagy135 closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants