Skip to content

feat: use distinct filter prompt titles #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2022
Merged

feat: use distinct filter prompt titles #671

merged 1 commit into from
Dec 28, 2022

Conversation

ttytm
Copy link
Contributor

@ttytm ttytm commented Dec 28, 2022

#670

The titles are inspired by modern file mangers like dolphin. Which use "Filter" for live filtering. "Search" for seraching on submit.

Screenshot_20221228_231549
Screenshot_20221228_231628

Please let me know if any changes are desired or feel free to submit as co-auth.

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #671 (1f4f76c) into main (3b41f0d) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   49.58%   49.48%   -0.11%     
==========================================
  Files          47       47              
  Lines        6304     6309       +5     
==========================================
- Hits         3126     3122       -4     
- Misses       3178     3187       +9     
Impacted Files Coverage Δ
lua/neo-tree/sources/filesystem/lib/filter.lua 11.11% <0.00%> (-0.50%) ⬇️
lua/neo-tree/sources/filesystem/init.lua 64.40% <0.00%> (-1.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@cseickel cseickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@cseickel cseickel merged commit d9e50c1 into nvim-neo-tree:main Dec 28, 2022
@ttytm
Copy link
Contributor Author

ttytm commented Dec 29, 2022

Thanks for merging!

What I see now is that I probably would have named the variable popup_title if I hadn't been working with messages prior to this pr, and if the day hadn't already ended for my brain. But such semantic bean counting can be done at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants