Skip to content

fix: delete neo-tree buffers created by :mksession #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2023
Merged

fix: delete neo-tree buffers created by :mksession #748

merged 2 commits into from
Feb 17, 2023

Conversation

nhat-vo
Copy link
Collaborator

@nhat-vo nhat-vo commented Feb 14, 2023

Hi! This PR fixes the issue in #740. I added a function to clean up the dummy neo-tree buffers the first time renderer.show() is called.

This is my first contribution to the project, so let me know if you have any comments 😅!

cseickel
cseickel requested changes Feb 14, 2023
View reviewed changes
@nhat-vo nhat-vo requested a review from cseickel February 16, 2023 15:42
@cseickel
Copy link
Contributor

Looks good, thanks!

@cseickel cseickel linked an issue Feb 17, 2023 that may be closed by this pull request
Restoring a session containing a neo-tree sidebar breaks neo-tree #740
Closed
@cseickel cseickel merged commit 93491a0 into nvim-neo-tree:main Feb 17, 2023
@nhat-vo nhat-vo deleted the 740-mksession-containing-neotree-buffer branch February 17, 2023 15:24
@nyngwang nyngwang mentioned this pull request Feb 18, 2023
Closed
@nhat-vo nhat-vo mentioned this pull request Feb 24, 2023
Closed
@mehalter
Copy link
Contributor

@nhat-vo @cseickel this breaks when using views in neovim with mkview and loadview. It seems that Neo-tree now thinks that it is restoring a session, so it closes the neotree sidebar that's open even though I'm not restoring an entire session. This needs to be fixed

@mehalter
Copy link
Contributor

Let me know if you want me to make a new issue regarding this @cseickel

@cseickel cseickel mentioned this pull request Feb 27, 2023
Closed
@nhat-vo
Copy link
Collaborator Author

nhat-vo commented Mar 1, 2023

@mehalter did you try to see if you encounter the issue in main branch? I pushed #771 a few days ago, which should fix this, but it hasn't been merged into release.

@mehalter
Copy link
Contributor

mehalter commented Mar 1, 2023

Ah, this does actually fix the problem thanks @nhat-vo even after re-enabling the new auto_clean_after_session_restore option! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cseickel cseickel cseickel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restoring a session containing a neo-tree sidebar breaks neo-tree
3 participants
@nhat-vo @cseickel @mehalter