feat(filesystem): use fd/find as first level filter in fzy, cancel jobs as needed #800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advantage here is that the fzy search will work in much larger directories because we no longer try to load all of the files and fzy search in memory. Now we will have a first level search using the external program which searches for the existence of all of the characters in the term.
The downside is that it will no longer find matches that are in a different order than what you type. I think that is a reasonable trade off because the old way was only usable in small projects.
If we want to recreate a perfect fzy search, we should just use fzy itself. I think we may be able to use nvim-fzf or at least lean from its code base.
The other change made here is that we now keep track of running jobs for the external find command and kill them when a new one comes in or when the search is exited.