fix: Preventing removal of necessary root separator on Windows #986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #985
When a root path was supplied as an argument to the Neotree command or to execute on Windows, the necessary separator was removed. ":Neotree C:", for instance, would become "C:" and this resulted in an empty listing.
Instead of testing if the length of args.dir is greater than 1, this now compares it to 3 on Windows while remaining 1 on other operating systems, including WSL.
I added a comment as well just to clarify what was going on. Though, maybe it'd be better to have a constant. In utils, there's an is_windows variable set (which includes WSL). Maybe a root_len should be set here as well? I'm going to leave it at this for now, though.