Skip to content

feat: expose store_link to agenda #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

thuyen
Copy link
Contributor

@thuyen thuyen commented Mar 8, 2025

Summary

As title, this PR exposes store_link to the Agenda API, so one can create links to headlines while in the agenda view.

Checklist

I confirm that I have:

  • Followed the
    Conventional Commits
    specification
    (e.g., feat: add new feature, fix: correct bug,
    docs: update documentation).
  • My PR title also follows the conventional commits specification.
  • Thoroughly tested my changes.
  • Checked for breaking changes and documented them, if any.

@thuyen thuyen changed the title feat: expose store_link to agenda . feat: expose store_link to agenda Mar 8, 2025
@kristijanhusak
Copy link
Member

Emacs exposes this through the global function as described here https://orgmode.org/manual/Handling-Links.html#Handling-Links-1.

Since we now have global Org command, I added a :Org store_link command that works in both agenda and org files.

@thuyen
Copy link
Contributor Author

thuyen commented Mar 14, 2025

But without remote_edit we cannot add link to an un-opened file from the agenda right? store_link_to_headline would hit error with get_valid_bufnr since there's no buffer for the file.

Probably we need to make store_link_to_headline works even when the file is not opened.

@kristijanhusak
Copy link
Member

Yes, I forgot about ID part. Pushed a fix for that, should be working fine now.

@thuyen thuyen deleted the agenda_store_link branch March 16, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants