Skip to content

fix(treesitter): Allow tree-sitter grammar installation outside of orgmode folder #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025

Conversation

kristijanhusak
Copy link
Member

Summary

Allow tree-sitter grammar for Org to be installed outside of orgmode installation directory, either via nix or luarocks.

Related Issues

Related #967

Changes

  • Allow parser to be installed outside of the orgmode installation directory
  • Report conflicting parsers only if there is more than 1 installation found
  • Track/report the version and attempt to update/reinstall only if parser is installed by nvim-orgmode in the orgmode installation directory.
  • Compiled parser is now moved via CLI mv command (or Windows move cmd) instead of fs_copyfile. fs_copyfile caused Neovim to crash when updating/reinstalling. This is also how nvim-treesitter does it.

Checklist

I confirm that I have:

  • Followed the
    Conventional Commits
    specification
    (e.g., feat: add new feature, fix: correct bug,
    docs: update documentation).
  • My PR title also follows the conventional commits specification.
  • Updated relevant documentation, if necessary.
  • Thoroughly tested my changes.
  • Added tests (if applicable) and verified existing tests pass with
    make test.
  • Checked for breaking changes and documented them, if any.

@kristijanhusak kristijanhusak force-pushed the fix/ts-install branch 2 times, most recently from 1d31ac8 to 61006c1 Compare May 11, 2025 19:12
@kristijanhusak kristijanhusak merged commit b22523c into master May 11, 2025
35 of 39 checks passed
@kristijanhusak kristijanhusak deleted the fix/ts-install branch May 11, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant