Skip to content

feat: creating, copying & moving in folder_browser #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

fdschmidt93
Copy link
Member

Closes #78

This commit enables creating, copying, and moving
files and folders from within folder_browser mode.

In doing so, the currently selected directory within
folder_browser serves as the target directory for the
corresponding telescope-file-browser action.

@fdschmidt93
Copy link
Member Author

fdschmidt93 commented Jan 20, 2022

@ikerurda would you mind testing that

  1. Copying, creating, moving files in file_browser mode works as you'd expect from current things
  2. Copying, creating, moving files to the currently selected entry of the folder browser works as expected?
  3. Copying a selected directory in folder browser should trigger that folder browser exists and that you can create a copy with a different name

That would be very much appreciated :) I've tried it once, and after I fixed that copying a selected folder in-place leads to recursively copying, I think it's good 😆

E: I also need to mark new behaviour on the README then.

@ikerurda
Copy link
Contributor

LGTM, and very cool!

Maybe we should add the destination path to the confirmation message, that would make it clearer.
What do you think?

@fdschmidt93
Copy link
Member Author

Thanks :)

Do you mean the target_dir? name is already printed. I agree that can be improved, but I'd merge now as state-of-things suffice and will revamp messages/notifications eventually ideally via #72

This commit enables creating, copying, and moving
files and folders from within folder_browser mode.

In doing so, the currently selected directory within
folder_browser serves as the target directory for the
corresponding telescope-file-browser action.
@fdschmidt93 fdschmidt93 force-pushed the feat/folder-browser-actions branch from 4d3f428 to faefd85 Compare January 20, 2022 20:37
@fdschmidt93 fdschmidt93 merged commit e65a567 into master Jan 20, 2022
@fdschmidt93 fdschmidt93 deleted the feat/folder-browser-actions branch January 20, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folder Browser Create File in selected folder
2 participants