The cmdheight setting is not kept when closing when open_replacing_current_buffer is used.

[vheon]

Description

The cmdheight settings doesn't seems to be kept when open_replacing_current_buffer is used and then the close action is issued.

Neovim version

NVIM v0.9.0-dev-91-gd339b4aad
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Operating system and version

Linux 5.15.0-48-generic

nvim-tree version

b01e7be

Minimal config

vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvt-min/site]]
local package_root = "/tmp/nvt-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup {
    {
      "wbthomason/packer.nvim",
      "nvim-tree/nvim-tree.lua",
      "nvim-tree/nvim-web-devicons",
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  }
end
if vim.fn.isdirectory(install_path) == 0 then
  print "Installing nvim-tree and dependencies."
  vim.fn.system { "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path }
end
load_plugins()
require("packer").sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua setup()]]
vim.opt.termguicolors = true
vim.opt.cursorline = true

-- MODIFY NVIM-TREE SETTINGS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
vim.opt.cmdheight = 2
_G.setup = function()
  require("nvim-tree").setup {
    view = {
      mappings = {
        list = {
          { key = "<CR>", action = "edit_in_place" },
          { key = "<C-e>", action = "edit" }
        }
      }
    },
    actions = {
      open_file = {
        quit_on_open = true
      }
    }
  }
end

Steps to reproduce

1. vim -nu /tmp/nvt-min.lua
2. :e /tmp/nvt-min.lua
3. :lua require"nvim-tree".open_replacing_current_buffer()
4. q

Expected behavior

the cmdheight property is kept to the original value of 2

Actual behavior

the cmdheight is set to 1

[alex-courtis]

Confirmed for both quit_on_open cases.

[alex-courtis]

related #1506

[alex-courtis]

This is a difficult one. The change for cmdheight occurs after any :sb from the nvim-tree window.

[alex-courtis]

rm /tmp/vf.log; nd -V100/tmp/vf.log README.md
:lua require"nvim-tree".open_replacing_current_buffer()
:verbose set cmdheight?
:sb 1
:verbose set cmdheight?

Executing: verbose set cmdheight?
  cmdheight=5
        Last set from ~/.local/share/nvim/nvt-dev.lua line 31
...
Executing: verbose set cmdheight?
  cmdheight=1
        Last set from ~/.local/share/nvim/nvt-dev.lua line 31

I don't see anything enlightening in between and last set is not helpful/incorrect.

vf.sb.log

[alex-courtis]

This might not be an nvim-tree issue. The challenge is to reproduce without nvim-tree.

[alex-courtis]

Looks like this one's resolved at nvim 0.9.4

There has been some activity around that area...

open_replacing_current_buffer is dead code. Removing.