Skip to content

fix(#3134): setting one glyph to "" no longer disables others #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

simonmandlik
Copy link
Collaborator

@simonmandlik simonmandlik commented May 25, 2025

fixes #3134

@simonmandlik simonmandlik requested a review from alex-courtis May 25, 2025 19:16
@alex-courtis alex-courtis changed the title fix: fixes #3134 fix(#3134): setting one glyph to "" no longer disables others May 26, 2025
Copy link
Member

@alex-courtis alex-courtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the great fix!

@alex-courtis
Copy link
Member

Tested OK in a sampling of situations.

Definitely a bug.

@alex-courtis alex-courtis merged commit ebcaccd into master May 26, 2025
6 checks passed
@alex-courtis alex-courtis deleted the 3134-fix branch May 26, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: "blank" icon glyphs turn off all icons of that type
2 participants