Skip to content

Regression: NvimWebDeviconsHiTest crashes #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simeonoff opened this issue Mar 18, 2024 · 5 comments · Fixed by #423
Closed

Regression: NvimWebDeviconsHiTest crashes #419

simeonoff opened this issue Mar 18, 2024 · 5 comments · Fixed by #423
Labels
awaiting response bug Something isn't working

Comments

@simeonoff
Copy link

simeonoff commented Mar 18, 2024

I believe after merging this PR the panel now crashes with:

Screenshot 2024-03-18 at 08 36 45

I have the font-symbols-only-nerd-font cask installed via brew(macOS) which is at version 3.1.1 of the nerd font symbols and they don't include the prettier icon.

@simeonoff simeonoff changed the title Regression: NvimWebDeviconsHiTest Regression: NvimWebDeviconsHiTest crashes Mar 18, 2024
@simeonoff simeonoff changed the title Regression: NvimWebDeviconsHiTest crashes Regression: NvimWebDeviconsHiTest crashes Mar 18, 2024
@simeonoff
Copy link
Author

My bad, it was down to the way I have overwritten the config for some icons. 🫣

@alex-courtis
Copy link
Member

This should be hardened / fixed. The failed icon can be shown as an error.

@alex-courtis
Copy link
Member

Fix incoming: #423

@simeonoff I'd be most grateful if you could test this one with your original case:

cd /path/to/nvim-web-devicons
git pull
git checkout 419-hi-test-fail-on-bad-icon

When you're finished testing:

git checkout master

@alex-courtis alex-courtis added bug Something isn't working awaiting response labels Mar 20, 2024
@simeonoff
Copy link
Author

@simeonoff I'd be most grateful if you could test this one with your original case:

Will do!

@simeonoff
Copy link
Author

simeonoff commented Mar 20, 2024

Ok, tested it, works like a charm! No more errors being thrown.

Edit: Also nice to see a list of which icons have been overridden.

alex-courtis added a commit that referenced this issue Mar 23, 2024
)

* fix(#419): HiTest shows overrides, add missing override_by_operating_system

* fix(#419): HiTest harden
olivertzeng pushed a commit to olivertzeng/nvim-web-devicons that referenced this issue Mar 23, 2024
…system (nvim-tree#423)

* fix(nvim-tree#419): HiTest shows overrides, add missing override_by_operating_system

* fix(nvim-tree#419): HiTest harden
alex-courtis added a commit that referenced this issue Mar 24, 2024
* feat: add zsh, theos tweak, and localization files icon

add .zsh_plugins.txt
add .zsh_history
add init.lua
add .m
add .strings
add .po
add .x
add .xm
add .xcstrings

* fixed .zsh_history .lock added .lck removed init.lua

fixed .zsh_history
fixed .lock
added .lck
removed init.lua

* fix(#419): harden HiTest, add missing override_by_operating_system (#423)

* fix(#419): HiTest shows overrides, add missing override_by_operating_system

* fix(#419): HiTest harden

* feat: add gradle icons (#426)

Co-authored-by: Alexander Courtis <[email protected]>

feat: add gradle icons (#426)

Co-authored-by: Alexander Courtis <[email protected]>

* 🐛fix: xm x m removed .zsh stuff

🐛fix: xm x m removed .zsh stuff

fixed x xm

Update icons-default.lua

Co-authored-by: gegoune <[email protected]>

Update icons-default.lua

Co-authored-by: gegoune <[email protected]>

* follow naming conventions for objective c

---------

Co-authored-by: Alexander Courtis <[email protected]>
Co-authored-by: Alexandros Alexiou <[email protected]>
Co-authored-by: gegoune <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants