Skip to content

Display git version + username #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
o2sh opened this issue Oct 23, 2019 · 8 comments · Fixed by #107
Closed

Display git version + username #106

o2sh opened this issue Oct 23, 2019 · 8 comments · Fixed by #107
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@o2sh
Copy link
Owner

o2sh commented Oct 23, 2019

On top of the repository infos, we would like to show general information (not specific to the repo), like git username (git config user.name) and the version of Git installed on the machine (git --version). Something like -->

Untitled

💯 🥇

@o2sh o2sh added enhancement New feature or request help wanted Extra attention is needed hacktoberfest labels Oct 23, 2019
@pablodiegoss
Copy link
Contributor

pablodiegoss commented Oct 23, 2019

I've tried to replicate your prototype on #107, what do you think?

Screenshot from 2019-10-23 11-12-51

@o2sh
Copy link
Owner Author

o2sh commented Oct 23, 2019

Great start @pablodiegoss

Few remarks:

  • The dotted line has to match the length of the displayed info, in this case: Pablo Diego: git version 2.20.1
  • You have to handle the case where the git username is unknown --> Don't print ":" at the start

Looking forward to merge your PR 👍

@pablodiegoss
Copy link
Contributor

Nice!
I'll work on those remarks then :)

@pablodiegoss
Copy link
Contributor

After formatting the line and username case it looks like this

With username:
Screenshot from 2019-10-23 12-17-33

And without:
Screenshot from 2019-10-23 12-18-30

@o2sh
Copy link
Owner Author

o2sh commented Oct 23, 2019

Looking better @pablodiegoss

Last remarks:

  • The text has to be diplayed in bold (except the dotted line), you should check Add flag to disable/enable boldness #99 (already merged) to make sure that we can disable boldness on your text too
  • We can't see it in your example, but the text should be displayed in color (like the info titles); by text I don't include the dotted line and the separator --> only git username and git version

🥇

@pablodiegoss
Copy link
Contributor

I've updated the color and bold o/
Screenshot from 2019-10-24 12-22-34

@o2sh
Copy link
Owner Author

o2sh commented Oct 24, 2019

Almost there @pablodiegoss

  • don't include the dotted line and the separator

The separator ":" has to be displayed without color.

@pablodiegoss
Copy link
Contributor

Sorry, forgot about the separator, should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants