Skip to content

Add Git info for user and version #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 24, 2019
Merged

Add Git info for user and version #107

merged 8 commits into from
Oct 24, 2019

Conversation

pablodiegoss
Copy link
Contributor

@pablodiegoss pablodiegoss commented Oct 23, 2019 •
edited
Loading

Resolves: #106
I'm new to rust, but i think i've solved the issue or at least contributed to it :D

@pablodiegoss pablodiegoss mentioned this pull request Oct 23, 2019
Closed
spenserblack
spenserblack reviewed Oct 23, 2019
View reviewed changes
spenserblack
spenserblack reviewed Oct 24, 2019
View reviewed changes
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 👍
Just left a few comments to help you get more familiar with Rust.

@o2sh
Copy link
Owner

o2sh commented Oct 24, 2019

@spenserblack Don't hesitate to merge this one when your code review is done.

@spenserblack spenserblack merged commit 908c866 into o2sh:master Oct 24, 2019
o2sh added a commit that referenced this pull request Oct 24, 2019
@o2sh
slight refacto of #107 and change separator
c0d1689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenserblack spenserblack spenserblack left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display git version + username
3 participants
@pablodiegoss @o2sh @spenserblack