Skip to content

cargo test after cargo build, or cargo build --release #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kloenk opened this issue Oct 27, 2019 · 2 comments
Closed

cargo test after cargo build, or cargo build --release #117

kloenk opened this issue Oct 27, 2019 · 2 comments

Comments

@kloenk
Copy link
Contributor

kloenk commented Oct 27, 2019

Looking forward to merging your PR 👍 ! Just one quick question:
Why move cargo build below cargo test? Tests require a successful build. If the project has not been built, cargo test will build it, so building after tests have run successfully is a bit redundant.

Originally posted by @spenserblack in #110

This is still unresolved, as we did not decide if we should move cargo test arround, or make the build a release build, becaus of maybe some different output in dependencies.

@spenserblack
Copy link
Collaborator

Thanks, completely missed that!
@o2sh, do you have a preference to the order that Travis-CI does these tasks?

@kloenk
Copy link
Contributor Author

kloenk commented Oct 27, 2019

I still believe that we should do a release build for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants